feat: expose fetch to custom functions #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marbemac can you think of any functions that might be useful from the perspective of Studio user? |
P0lip
force-pushed
the
feat/expose-fetch
branch
from
454108b
to
8370a05
Compare
nulltoken
reviewed
Apr 13, 2020
4 tasks
|
@nulltoken mind taking a stab at reviewing the PR? |
nulltoken
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Does this PR introduce a breaking change?
Additional context
Make sure to select this option before you start reviewing
I moved a few tests under the same block and therefore the diff is slightly noisier than it could be.
I didn't update documentation, since despite having access to fetch, you cannot really use it until the support for async functions #1058 is brought.